kirklund commented on a change in pull request #6052:
URL: https://github.com/apache/geode/pull/6052#discussion_r586714691
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/BucketRegionQueue.java
##########
@@ -453,21 +454,22 @@ public Object peek() {
* If a matching object also fulfills the endPredicate then the method
* stops looking for more matching objects.
*/
- public List<Object> getElementsMatching(Predicate matchingPredicate,
Predicate endPredicate) {
+ public List<Object> getElementsMatching(Predicate<GatewaySenderEventImpl>
matchingPredicate,
Review comment:
You might want to change from `GatewaySenderEventImpl` to your new
`InternalGatewaySenderEvent` everywhere you've added new code. I don't see
anything that would obviously break.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]