Bill commented on a change in pull request #6083:
URL: https://github.com/apache/geode/pull/6083#discussion_r586849213
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/monitoring/ThreadsMonitoringImplDummy.java
##########
@@ -32,9 +32,17 @@ public boolean startMonitor(Mode mode) {
@Override
public void endMonitor() {}
+ private static class DummyAbstractExecutor extends AbstractExecutor {
+ private static final DummyAbstractExecutor SINGLETON = new
DummyAbstractExecutor();
+
+ private DummyAbstractExecutor() {
+ super("dummyExecutorGroup", 0L);
Review comment:
From looking at other group names they are typically capitalized like
class names and don't end in the word `Group`. So I recommend:
`"DummyExecutor"`
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/monitoring/ThreadsMonitoringImplDummy.java
##########
@@ -32,9 +32,17 @@ public boolean startMonitor(Mode mode) {
@Override
public void endMonitor() {}
+ private static class DummyAbstractExecutor extends AbstractExecutor {
Review comment:
I think this new class is not meant to be subclassed so I recommend
removing `Abstract` from the name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
