agingade commented on pull request #6075:
URL: https://github.com/apache/geode/pull/6075#issuecomment-796264564


   > There is a behavior change in transaction with register interest. (From my 
understanding this behavior exists from start of the tx implementation).
   > Now register interest will block transaction commit during the period of 
register interest -- esp. on the node performing the register interest from 
client.
   > The performance hit shifts from calculating filterRoutingInfo again on 
remote node to no transactions allowed to commit when register interest is 
under way.
   > Also I worry about potential performance hit and even deadlock as the 
remote node processing register interest message can be blocked for a while 
(trying to get the write lock) while there are concurrent transactions.
   
   Not sure what you meant by behavior change; can you be more explicit on this.
   By design for partitioned regions, the events are processed on the primary 
bucket (where cache is updated) for all the peer-nodes and server hosting the 
subscription queues in questions. And replicated regions its processed locally 
in notifyBridgeClientes()
   
   Yes. With the new change register interest is blocked while transaction in 
progress (and other way); this is one of the option that address the issue we 
are seeing. We could try out if there are any other better option to address 
this.
   
   There could be impact when the registration and transaction in progress; but 
considering the use-case, where registration is meta operation (only happens 
initially when client comes up); it will have minimal impact. Also we have nice 
mentioned that overall transaction ops are slower compare to non-tx ops.
   
   Yes, we need add/run tests to make sure there is no dead-lock issue within 
the node and between the nodes (distributed message).
    


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to