agingade commented on a change in pull request #6104:
URL: https://github.com/apache/geode/pull/6104#discussion_r591936422
##########
File path:
geode-core/src/test/java/org/apache/geode/internal/cache/DistributedPutAllOperationTest.java
##########
@@ -33,4 +47,39 @@ public void shouldBeMockable() throws Exception {
assertThat(mockDistributedPutAllOperation.getBaseEvent()).isSameAs(mockEntryEventImpl);
}
+
+ @Test
+ public void testDoRemoveDestroyTokensFromCqResultKeys() {
Review comment:
A small refactoring request...to make it readable, can this be broken
down (with new lines) into:
setup
action
validation/verification
##########
File path:
geode-cq/src/distributedTest/java/org/apache/geode/cache/query/cq/dunit/PartitionedRegionCqQueryDUnitTest.java
##########
@@ -120,6 +125,109 @@
private static int bridgeServerPort;
+ @Test
+ public void testPutAllWithCQLocalDestroy() {
+ VM server1 = getVM(0);
+ VM server2 = getVM(1);
+ VM client = getVM(2);
+
+ final String cqName = "testPutAllWithCQLocalDestroy_0";
+ createServer(server1);
+ createServer(server2);
+ final String host = VM.getHostName();
+ final int port = server2.invoke(() -> getCacheServerPort());
+ createClient(client, port, host);
+ createCQ(client, cqName, cqs[0]);
+
+ int numObjects = 1000;
Review comment:
Does this need to be that big...If its not needed can we keep it small,
say 5 or 10. Makes test to run faster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
