bschuchardt commented on a change in pull request #6100:
URL: https://github.com/apache/geode/pull/6100#discussion_r592542153
##########
File path:
geode-membership/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
##########
@@ -1456,12 +1456,18 @@ void
processNetworkPartitionMessage(NetworkPartitionMessage<ID> msg) {
return;
}
ID sender = msg.getSender();
- if (getView().getMembers().contains(sender)) {
- String str = "Membership coordinator " + msg.getSender()
- + " has declared that a network partition has occurred";
- forceDisconnect(str);
+
+ if (getView() != null && isJoined) {
+ if (getView().getMembers().contains(sender)) {
+ String str = "Membership coordinator " + msg.getSender()
+ + " has declared that a network partition has occurred";
+ forceDisconnect(str);
+ } else {
+ logger.warn("Ignoring the network partition message from a non-member:
" + msg.getSender());
+ }
} else {
- logger.warn("Ignoring the network partition message from a non-member: "
+ msg.getSender());
+ logger.debug(
+ "Ignoring, likely this message was intended for the previous
Membership service... ");
Review comment:
I'd like to see more detail about what's being ignored. If I saw this
message in a log I wouldn't know what it means. How about logging the message
itself? That would show what it is and who sent it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
