moleske opened a new pull request #6125:
URL: https://github.com/apache/geode/pull/6125
- make a visible for testing function that takes in filestreams of
netstats and stats
- since it is an integration test anyway, just read real files from test
resources
- use variable name `ignore` for exceptions we catch but don't do
anything with
- remove unneeded initialization of String
- remove empty if clause
- remove unneeded assignments
- simplify condition check
- replace explicit type with <>
Was getting the ruby taste out of my mouth from another project and thought
I'd tackle another powermock removal.
Anyone who has push access to the apache/geode repo can push changes my
branch, so please do so if you see changes that need to happen
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
There's a commit with the actual change and a follow up with cleaning up
some warnings. Who ever merges may squash into one.
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
