moleske opened a new pull request #765: URL: https://github.com/apache/geode-native/pull/765
- Add ifdef for enable/disable ipv6 test - Disable unit test when ipv6 is on - Add CI job to use WITH_IPV6=ON Authored-by: M. Oleske <[email protected]> I'd like to be able to run the BasicIPv6Test in my pipeline I keep for geode native. The recent changes to get a concourse ci marked the BasicIPv6Test as disabled. The test works fine when setting the WITH_IPV6 variable. This change enables the test when the flag is set and disables when not. When testing, I noticed all tests work with ipv6 except for the unit test QueueConnectionRequestTest, so went ahead and did a similar enable/disable. I don't know if I went the best way about doing this so wanted some feedback/collaboration since I feel weird enabling/disabling tests. I also added a change to ci/base/base.yml so that the pipeline could run the tests with ipv6. It only works on linux at the moment, so I chose ubuntu. I think it is valuable to run, but don't know if it should block releases. I haven't tested the concourse change, I would need help on that ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
