pivotal-jbarrett commented on a change in pull request #6117:
URL: https://github.com/apache/geode/pull/6117#discussion_r593461293
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/data/ByteArrayWrapper.java
##########
@@ -39,6 +45,8 @@
*/
protected byte[] value;
+ private transient Object routingId;
Review comment:
I would hope we only call it once for each incoming key operation. So
yes, calculating in the resolver would work but then we leak the internals of
`ByteArrayWrapper` to another class right? What if
`ByteArrayWrapper.hashCode()` was the CRC16 value, then we would be good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
