bschuchardt opened a new pull request #6165: URL: https://github.com/apache/geode/pull/6165
[This will require a subsequent change in develop to update KnownVersion 1.15] A client's version is used for deserializing data received from the client and for serializing data sent to the client. It is also used to locate the map of Commands used to process client requests. Every time we cut a new release we bump this version in KnownVersions and create a new map of Commands, even though client/server communications protocols rarely change. This PR changes KnownVersions to hold a client/server protocol version that is used to identify clients for command-table selection and serialization rather than the client's CURRENT_VERSION. Altered KnownVersions to just mark each version that has client/server protocol changes rather than store the last one having changes in the more recent instances. Release managers can continue to use the old constructor and coders can change to the new constructor if necessary during the course of a release. (cherry picked from commit dc3ed8c1af4389f60c8ad8e35c43a72731869dcc) Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to [email protected]. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
