pivotal-jbarrett commented on pull request #142: URL: https://github.com/apache/geode-benchmarks/pull/142#issuecomment-808369941
> > Benchmarks haven't been versioned or back ported ever. The current head is generally capable of compiling against all supported versions of Geode. I am kind of surprised to see that we even have support branches. I think you should probably just leave well enough alone and close this PR. Just keep the head working. > > The [support/1.14](https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-support-1-14-main/jobs/Benchmark_base/builds/38), [support/1.13](https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-support-1-13-main/jobs/Benchmark_base/builds/12) and [support/1.12](https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-support-1-12-main/jobs/Benchmark_base/builds/26) branches of Geode all currently use the corresponding benchmarks branch in CI. If that's not correct, then I think a discussion probably needs to be had with whoever maintains the CI pipelines for those branches. That being said, this PR wasn't correctly rebased against support/1.13 so it was closed and [this one](https://github.com/apache/geode-benchmarks/pull/144) opened to correctly backport just the build timeout fix (similarly for support/1.12). Yes, either the CI should use the head, which was the intent of the group doing the geode-benchmarks, or an effort should be made to back port changes regularly, which seems unsustainable given nobody is really contributing to geode-benchmarks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
