sabbey37 commented on a change in pull request #6211:
URL: https://github.com/apache/geode/pull/6211#discussion_r604137795
##########
File path:
geode-redis/src/acceptanceTest/resources/0001-configure-redis-tests.patch
##########
@@ -1,808 +0,0 @@
-From 15b752b4d129d4f303d033f0e6e63871355388cc Mon Sep 17 00:00:00 2001
Review comment:
This file needs to be added back. Right now the RedisTests aren't
really running at all because they're still looking for the `redisAPITest` task
in the `geode-redis` module.
This line in `execute_tests.sh` also needs to be updated to fix that issue:
```
if [ "${GRADLE_TASK}" = ":geode-redis:redisAPITest" ] && ! grep -q
redisAPITest geode/geode-redis/build.gradle ; then
```
We'll also need to update the `Redis` test section in the
`jinja.variables.yml` file, right now we have the following:
```
GRADLE_TASK: ':geode-redis:redisAPITest'
```
This line in `execute_redis_tests.sh` will also need to be updated with the
correct module name:
```
REDIS_PATCH=${PWD}/geode-redis/src/acceptanceTest/resources/0001-configure-redis-tests.patch
```
##########
File path:
geode-redis/src/acceptanceTest/resources/0001-configure-redis-tests.patch
##########
@@ -1,808 +0,0 @@
-From 15b752b4d129d4f303d033f0e6e63871355388cc Mon Sep 17 00:00:00 2001
Review comment:
This file needs to be added back. Right now the RedisTests aren't
really running at all because they're still looking for the `redisAPITest` task
in the `geode-redis` module.
This line in `execute_tests.sh` also needs to be updated to fix that issue:
```
if [ "${GRADLE_TASK}" = ":geode-redis:redisAPITest" ] && ! grep -q
redisAPITest geode/geode-redis/build.gradle ; then
```
We'll also need to update the `Redis` test section in the
`jinja.variables.yml` file, right now we have the following:
```
GRADLE_TASK: ':geode-redis:redisAPITest'
```
This line in `execute_redis_tests.sh` will also need to be updated with the
correct directory name:
```
REDIS_PATCH=${PWD}/geode-redis/src/acceptanceTest/resources/0001-configure-redis-tests.patch
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
