bschuchardt commented on a change in pull request #6219:
URL: https://github.com/apache/geode/pull/6219#discussion_r604210177
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java
##########
@@ -1502,25 +1503,15 @@ public void run() {
}
}
- releaseInputBuffer();
-
// make sure that if the reader thread exits we notify a thread waiting
for the handshake.
notifyHandshakeWaiter(false);
readerThread.setName("unused p2p reader");
synchronized (stateLock) {
isRunning = false;
readerThread = null;
}
- }
- }
- private void releaseInputBuffer() {
- synchronized (inputBufferLock) {
- ByteBuffer tmp = inputBuffer;
- if (tmp != null) {
- inputBuffer = null;
- getBufferPool().releaseReceiveBuffer(tmp);
- }
+ inputSharing.close();
Review comment:
I'm wondering if this method needs to claim its own reference to the
buffer to balance this close()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
