dschneider-pivotal commented on a change in pull request #6246:
URL: https://github.com/apache/geode/pull/6246#discussion_r605821565
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/persistence/PersistenceAdvisorImpl.java
##########
@@ -510,18 +510,18 @@ public PersistentMembershipView getMembershipView() {
public boolean checkMyStateOnMembers(Set<InternalDistributedMember>
replicates)
throws ReplyException {
PersistentStateQueryResults remoteStates = getMyStateOnMembers(replicates);
+ Set<InternalDistributedMember> copyOfReplicates = new
HashSet<>(replicates);
Review comment:
Instead of always having this code create a copy every time it is
called, start the copyofReplicates out as null. Then, in the exceptional case
when we need to remove from it (line 540), you can ask if it is null and then
make it a copy of replicates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
