jinmeiliao commented on a change in pull request #6196: URL: https://github.com/apache/geode/pull/6196#discussion_r605787272
########## File path: geode-assembly/src/acceptanceTest/java/org/apache/geode/management/LocatorManagerConfiguresSerialFilterAcceptanceTest.java ########## @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.geode.management; + +import static java.util.concurrent.TimeUnit.MILLISECONDS; +import static org.apache.commons.lang3.SystemUtils.isJavaVersionAtLeast; +import static org.apache.commons.lang3.SystemUtils.isJavaVersionAtMost; +import static org.apache.geode.internal.AvailablePortHelper.getRandomAvailableTCPPorts; +import static org.apache.geode.internal.lang.SystemUtils.isWindows; +import static org.apache.geode.test.awaitility.GeodeAwaitility.await; +import static org.apache.geode.test.awaitility.GeodeAwaitility.getTimeout; +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assumptions.assumeThat; + +import java.nio.file.Path; +import java.nio.file.Paths; + +import org.apache.commons.lang3.JavaVersion; +import org.junit.After; +import org.junit.Before; +import org.junit.Rule; +import org.junit.Test; +import org.junit.rules.TemporaryFolder; + +import org.apache.geode.management.internal.OpenJmxTypesSerialFilter; +import org.apache.geode.test.assertj.LogFileAssert; +import org.apache.geode.test.junit.rules.RequiresGeodeHome; + +public class LocatorManagerConfiguresSerialFilterAcceptanceTest { Review comment: Suggestion: using GfshRule to launch a locator/server would greatly reduce the boiler plate code ########## File path: geode-assembly/src/acceptanceTest/java/org/apache/geode/management/ServerManagerConfiguresSerialFilterAcceptanceTest.java ########## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.geode.management; + +import static java.util.concurrent.TimeUnit.MILLISECONDS; +import static org.apache.commons.lang3.SystemUtils.isJavaVersionAtLeast; +import static org.apache.commons.lang3.SystemUtils.isJavaVersionAtMost; +import static org.apache.geode.internal.AvailablePortHelper.getRandomAvailableTCPPort; +import static org.apache.geode.internal.lang.SystemUtils.isWindows; +import static org.apache.geode.test.awaitility.GeodeAwaitility.await; +import static org.apache.geode.test.awaitility.GeodeAwaitility.getTimeout; +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assumptions.assumeThat; + +import java.nio.file.Path; +import java.nio.file.Paths; + +import org.apache.commons.lang3.JavaVersion; +import org.junit.After; +import org.junit.Before; +import org.junit.Rule; +import org.junit.Test; +import org.junit.rules.TemporaryFolder; + +import org.apache.geode.management.internal.OpenJmxTypesSerialFilter; +import org.apache.geode.test.assertj.LogFileAssert; +import org.apache.geode.test.junit.rules.RequiresGeodeHome; + +public class ServerManagerConfiguresSerialFilterAcceptanceTest { Review comment: Suggestion: using GfshRule to launch a locator/server would greatly reduce the boiler plate code ########## File path: geode-core/src/main/java/org/apache/geode/management/internal/JmxRmiSerialFilter.java ########## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.geode.management.internal; + +@FunctionalInterface +public interface JmxRmiSerialFilter { + + /** + * Configure the “jmx.remote.rmi.server.serial.filter.pattern” system property if Java version is Review comment: this comment probably only applies to the implementor of the interface ########## File path: geode-core/src/main/java/org/apache/geode/management/internal/JmxRmiSerialFilter.java ########## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.geode.management.internal; + +@FunctionalInterface +public interface JmxRmiSerialFilter { + + /** + * Configure the “jmx.remote.rmi.server.serial.filter.pattern” system property if Java version is + * greater than Java 8. If the system property already has a non-null value with a length greater + * than zero, then leave it as is. + */ + void configureSerialFilterIfEmpty(); Review comment: This "if empty" is implementation specific. As an interface user, we just want to call `configureSerialFilter()`, as to whether/how you configure it, it depends on the implementer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
