DonalEvans commented on a change in pull request #6305:
URL: https://github.com/apache/geode/pull/6305#discussion_r611883738
##########
File path:
geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/AsyncEventQueueFactoryImpl.java
##########
@@ -281,6 +281,12 @@ public AsyncEventQueueFactory
setForwardExpirationDestroy(boolean forward) {
return this;
}
+ // keep this method internal
+ public AsyncEventQueueFactory setPartitionedRegionClearUnsupported(boolean
supported) {
+ gatewaySenderAttributes.partitionedRegionClearUnsupported = supported;
Review comment:
The method argument and field names here are confusing, as the field
name is tracking whether PR clear *is not* supported, but the method argument
name implies that it is setting whether PR clear *is* supported.
##########
File path:
geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionClearTest.java
##########
@@ -56,15 +57,19 @@
public class PartitionedRegionClearTest {
+ private GemFireCacheImpl cache;
+ private HashSet<AsyncEventQueue> allAEQs = new HashSet<>();
+ private PartitionedRegionClear partitionedRegionClear;
private DistributionManager distributionManager;
private PartitionedRegion partitionedRegion;
private RegionAdvisor regionAdvisor;
private InternalDistributedMember internalDistributedMember;
- private PartitionedRegionClear partitionedRegionClear;
-
@Before
public void setUp() {
+
+ cache = mock(GemFireCacheImpl.class);
+ partitionedRegion = mock(PartitionedRegion.class);
Review comment:
`partitionedRegion` is already defined on line 75, so this is redundant.
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java
##########
@@ -143,6 +143,12 @@
protected boolean forwardExpirationDestroy;
+ /**
+ * An attribute to specify if Partitioned region clear operation is
unsupported.
+ * Default is false, i.e.
Review comment:
This comment seems unfinished.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
