Bill commented on a change in pull request #6298:
URL: https://github.com/apache/geode/pull/6298#discussion_r612690648
##########
File path:
geode-membership/src/main/java/org/apache/geode/distributed/internal/membership/gms/messenger/JGroupsMessenger.java
##########
@@ -335,7 +335,9 @@ public void start() throws MemberStartupException {
try {
Object oldDSMembershipInfo = services.getConfig().getOldMembershipInfo();
if (oldDSMembershipInfo != null) {
- logger.debug("Reusing JGroups channel from previous system",
properties);
+ if (logger.isDebugEnabled()) {
Review comment:
I've changed my mind on this. I've learned that performance tests have
shown that Geode's logging infrastructure should have conditional guards around
log calls. A [Design
Decision](https://cwiki.apache.org/confluence/display/GEODE/Design+Decisions)
on this subject is coming from @kirklund that will describe the testing and the
resulting conclusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
