jvarenina commented on a change in pull request #6036:
URL: https://github.com/apache/geode/pull/6036#discussion_r612568919
##########
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/functions/GatewaySenderFunctionArgs.java
##########
@@ -47,6 +47,7 @@
private final List<String> gatewayEventFilters;
private final List<String> gatewayTransportFilters;
private final Boolean enforceThreadsConnectSameReceiver;
+ private final String state;
Review comment:
Hi @boglesby ,
I have covered the scenario when persistent parallel gateway sender is
started in "stopped" state in following commit:
https://github.com/apache/geode/pull/6036/commits/6abcb7aa7a027187afe64037e2a78e011f126d29
I only followed the similar scenario when gateway-sender is started, and
then stopped using gfsh commands. In that case all relevant threads that handle
events are stopped (no data is enqueued), but collocated queue and data regions
continue coexist and work. So in order to cover this problematic case, I only
bring gateway-sender to the same state as it would be after it is started and
then stopped by using gfsh commands (start and stop gateway-sender).
You can find more information in below TC's that verify the solution. I
tried to describe every TC in comment block just before the each case, so it
would be easier to review. Hope this will help.
- ParallelGatewaySenderOperationClusterConfigDUnitTest.java
- ParallelGatewaySenderOperationClusterConfigDUnitTest.java
I would be really grateful if you could share your opinion on this solution.
Also, I just noticed that I have missed to introduced the changes you proposed
in your first two comments. I will introduce them in next commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
