albertogpz commented on pull request #783: URL: https://github.com/apache/geode-native/pull/783#issuecomment-819597609
> > I wonder if it would make more sense to write a JIRA to fix the problem caused by the GEODE-8231 PR instead of reverting 3 PRs that have been for months in the develop branch. > > I do not know if I understood correctly the issue but wouldn't a possible solution be to change the eventId of the "leftover" keys (the keys for those puts that were not sent because the server went down) before sending them in the new thread to another server? > > If we did so, we could keep the code in the "PRs to be reverted", fix the issue and have a test case to verify that everything works as expected. > > I'm looking into it - don't think this one is going to be merged right away, because the fix may be simpler and IMO lower-risk than reverting all this code. Writing the test is going to be tough - we had to modify Geode server code in order to reproduce the issue in the first place. At any rate I'll update things here. Great. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
