DonalEvans commented on a change in pull request #6347:
URL: https://github.com/apache/geode/pull/6347#discussion_r616833221
##########
File path:
geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterOperationExecutors.java
##########
@@ -680,10 +678,10 @@ public void
handleManagerDeparture(InternalDistributedMember theId) {
}
/*
- * Returns an id of the thread in serialQueuedExecutorMap, thats mapped to
the given seder.
+ * Returns an id of the thread in serialQueuedExecutorMap, that's mapped
to the given seder.
Review comment:
Typo here, should be "sender". Also, the comma should probably be
removed.
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionStats.java
##########
@@ -425,7 +425,13 @@
false),
f.createLongGauge("localMaxMemory",
- "local max memory in bytes for this region on this member",
"bytes")
+ "local max memory in bytes for this region on this member",
"bytes"),
+ f.createLongCounter("partitionedRegionClearLocalDuration",
+ "The time in nanoseconds partitioned region clear has been
running for the region on this member",
+ "nanoseconds"),
+ f.createLongCounter("partitionedRegionClearTotalDuration",
+ "The time in nanoseconds partitioned region clear has been
running for the region with this member as coordinator.",
+ "nanoseconds"),
Review comment:
These stats are newly added with this PR, which seems like an accidental
inclusion.
##########
File path:
geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterOperationExecutors.java
##########
@@ -680,10 +678,10 @@ public void
handleManagerDeparture(InternalDistributedMember theId) {
}
/*
- * Returns an id of the thread in serialQueuedExecutorMap, thats mapped to
the given seder.
+ * Returns an id of the thread in serialQueuedExecutorMap, that's mapped
to the given seder.
*
*
- * @param createNew boolean flag to indicate whether to create a new id,
if id doesnot exists.
+ * @param createNew boolean flag to indicate whether to create a new id,
if id does not exists.
Review comment:
Typo here, should be "exist".
##########
File path:
geode-core/src/main/java/org/apache/geode/distributed/internal/LonerDistributionManager.java
##########
@@ -1045,16 +1034,16 @@ public Set getAllRoles() {
private int lonerPort = 0;
- // private static final int CHARS_32KB = 16384;
+ // private static final long CHARS_32KB = 16384;
Review comment:
This commented out line can be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
