pivotal-jbarrett commented on a change in pull request #149:
URL: https://github.com/apache/geode-benchmarks/pull/149#discussion_r616992134
##########
File path:
infrastructure/src/main/java/org/apache/geode/infrastructure/aws/LaunchCluster.java
##########
@@ -241,19 +241,21 @@ private static void createKeyPair(String benchmarkTag)
throws IOException {
private static void createMetadata(String benchmarkTag, List<String>
publicIps)
throws IOException {
UUID instanceId = UUID.randomUUID();
- JSONObject metadataJSON = new JSONObject();
-
- metadataJSON.put("instanceId", instanceId.toString());
- metadataJSON.put("publicIps", new JSONArray(publicIps));
+ // TODO - Filter out only benchmark properties from system properties?
Maybe not necessary.
Review comment:
Please cleanup TODO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
