mkevo commented on a change in pull request #6351:
URL: https://github.com/apache/geode/pull/6351#discussion_r618132525



##########
File path: 
geode-lucene/src/upgradeTest/java/org/apache/geode/cache/lucene/RollingUpgradeQueryReturnsCorrectResultsAfterClientAndServersAreRolledOverAllBucketsCreated.java
##########
@@ -31,6 +32,7 @@
 public class 
RollingUpgradeQueryReturnsCorrectResultsAfterClientAndServersAreRolledOverAllBucketsCreated
     extends LuceneSearchWithRollingUpgradeDUnit {
 
+  @Ignore

Review comment:
       The main sequence in this test that causes the failure is:
   
   
   1. start two servers with old version using Lucene 6
   2. roll one server to new version server using Lucene 7
   3. do puts into primary buckets in new server which creates entries in the 
fileAndChunk region with Lucene 7 format
   4. stop the new version server which causes the old version server to become 
primary for those buckets
   5. do a query which causes the IndexFormatTooNewException to be thrown
   
   So the old server cannot read the new index format. This test can be valid 
for the version of the Geode which is using Lucene without changes in index 
format.
   

##########
File path: 
geode-lucene/src/upgradeTest/java/org/apache/geode/cache/lucene/LuceneSearchWithRollingUpgradeDUnit.java
##########
@@ -142,23 +142,17 @@ void executeLuceneQueryWithServerRollOvers(String 
regionType, String startingVer
 
       server1 = rollServerToCurrentCreateLuceneIndexAndCreateRegion(server1, 
regionType,
           testingDirs[0], shortcutName, regionName, locatorPorts, reindex);
-      verifyLuceneQueryResultInEachVM(regionName, expectedRegionSize, server1);
       expectedRegionSize += 5;
-      putSerializableObjectAndVerifyLuceneQueryResult(server1, regionName, 
expectedRegionSize, 5,
-          15, server2, server3);
+      putSerializableObject(server1, regionName, 5, 15);

Review comment:
       Between Lucene version happened changes on Lucene format, so it cannot 
read with old server new indexes. So we agree on the dev list to queue puts 
until all members are upgraded. You can find it in the description of this PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to