alb3rtobr commented on pull request #6116: URL: https://github.com/apache/geode/pull/6116#issuecomment-824633211
> I've read the ticket and made a first pass over the diffs, but I don't understand why StartLocatorCommandWorkingDirectoryTest and StartServerCommandWorkingDirectoryTest need to be deleted in order to support configurable UDP membership address? It is not needed. Its a code improvement I identified when implementing the functionality. Notice what I wrote on the PR description: > I have not squashed the commits of the PR because I think it can be useful for reviewers. The two first commits contains the functionality I mentioned previously, while the three next commits contains some code improvements identified after the review of my first PR for this ticket. Long story: I observed that adding a new parameter in `start locator` or `start server` commands had an impact on all tests of `StartLocatorCommandWorkingDirectoryTest` and `StartLocatorCommandWorkingDirectoryTest`. Those tests were just testing the working directory resolution, it has no sense they were impacted. So I refactored that code in `StartLocatorCommand` & `StartServerCommand` extracting the working directory resolution code to a new method to be able to test it independently. You can review just what I changed for this in this commit: `4cd39cc Refactor StartMemberUtils.resolveWorkingDir` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
