bschuchardt commented on a change in pull request #6360:
URL: https://github.com/apache/geode/pull/6360#discussion_r618645034
##########
File path:
geode-membership/src/main/java/org/apache/geode/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
##########
@@ -1538,4 +1463,114 @@ public void run() {
public MembershipStatistics getStats() {
return this.stats;
}
+
+ @FunctionalInterface
+ interface Sleeper {
+ void sleep(long millis) throws InterruptedException;
+ }
+
+ @FunctionalInterface
+ interface NanoTimer {
+ long nanoTime();
+ }
+
+ @FunctionalInterface
+ interface Warner {
+ void warn(String message);
+ }
+
+ class Heart implements Runnable {
+
+ public final long sleepPeriodMillis = memberTimeout / LOGICAL_INTERVAL;
+ public final long sleepPeriodNanos =
+ TimeUnit.NANOSECONDS.convert(sleepPeriodMillis, TimeUnit.MILLISECONDS);
+ public final long sleepLimitNanos = 2 * sleepPeriodNanos;
+
+ @Override
+ public void run() {
+ Thread.currentThread().setName("Geode Heartbeat Sender");
+ sendPeriodicHeartbeats(Thread::sleep, System::nanoTime, logger::warn);
+ }
+
+ @VisibleForTesting
+ void sendPeriodicHeartbeats(final Sleeper sleeper,
Review comment:
I like this nice injection of time-related functions and the log message
consumer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
