[GitHub] [geode] Bill commented on a change in pull request #6343: GEODE-9141: fixed via ByteBufferSharing on Connection input buffer

Thu, 22 Apr 2021 12:47:37 -0700 


Bill commented on a change in pull request #6343:
URL: https://github.com/apache/geode/pull/6343#discussion_r618692681



##########
File path: 
geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java
##########
@@ -1617,8 +1612,18 @@ private void readMessages() {
           break;
         }
 
-        try {
-          ByteBuffer buff = getInputBuffer();
+        try (final ByteBufferSharing inputSharing = inputBufferVendor.open()) {

Review comment:
       moving initial buffer size calculation "up" (not quite to 
constructors—but into `createIOFilter()` which is about as good), in next 
commit…




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to