jinmeiliao commented on a change in pull request #6367:
URL: https://github.com/apache/geode/pull/6367#discussion_r622338636
##########
File path:
geode-core/src/main/java/org/apache/geode/management/internal/i18n/CliStrings.java
##########
@@ -2624,14 +2625,22 @@
public static final String START_SERVER__PROPERTIES = "properties-file";
public static final String START_SERVER__PROPERTIES__HELP =
"The gemfire.properties file for configuring the Cache Server's
distributed system. The file's path can be absolute or relative to the gfsh
working directory.";
+ @Experimental
public static final String START_SERVER__REDIS_BIND_ADDRESS =
ConfigurationProperties.REDIS_BIND_ADDRESS;
+ @Experimental
Review comment:
do we need to add `@experimental` tag to the `internal` packages?
##########
File path:
geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java
##########
@@ -1965,7 +1980,12 @@
* <U>Default</U>: 6379
* </p>
* <U>Allowed values</U>: 0..65535
+ *
+ * <p>
+ * Experimental: Geode API compatible with Redis is a new addition to Geode
and the API may change
+ * <p/>
*/
+
String REDIS_PORT = "compatible-with-redis-port";
Review comment:
Here we will need the `@Experimental` tag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
