gaussianrecurrence commented on a change in pull request #792:
URL: https://github.com/apache/geode-native/pull/792#discussion_r622427386
##########
File path: cppcache/src/TcrEndpoint.cpp
##########
@@ -504,14 +504,15 @@ void TcrEndpoint::pingServer(ThinClientPoolDM* poolDM) {
}
if (!m_msgSent && !m_pingSent) {
- TcrMessagePing* pingMsg = TcrMessage::getPingMessage(m_cacheImpl);
+ TcrMessagePing pingMsg(new DataOutput(m_cacheImpl->createDataOutput()),
Review comment:
This pointer ownership is transfered to the TcrMessage by assigning it
to an unique_ptr. I am with you that the way of instantiating the object might
lead to think that this is a memory leak, but this is they way is done for most
of the TcrMessage implementations :S
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
