bschuchardt opened a new pull request #6392: URL: https://github.com/apache/geode/pull/6392
A not serializable exception can cause a ServerConnection thread to get stuck waiting for a reply from another member. This is caused by ReplyMessage not handling a non-serializable "returnValue". The fix is to catch and log the exception in the sending node and then handle the problem in the receiving node. I would have liked to serialize the "returnValue" field into a separate buffer so as not to transmit a partial serialization of the object but that would require an extra buffer copy for every ReplyMessage sent, and we send a lot of them. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to [email protected]. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
