pivotal-jbarrett commented on a change in pull request #793:
URL: https://github.com/apache/geode-native/pull/793#discussion_r622595152
##########
File path: cppcache/src/CacheImpl.cpp
##########
@@ -706,16 +706,16 @@ void CacheImpl::processMarker() {
if (!kv.second->isDestroyed()) {
if (const auto tcrHARegion =
std::dynamic_pointer_cast<ThinClientHARegion>(kv.second)) {
- auto regionMsg = new TcrMessageClientMarker(
- new DataOutput(createDataOutput()), true);
- tcrHARegion->receiveNotification(regionMsg);
+ tcrHARegion->receiveNotification(
+ std::unique_ptr<TcrMessage>(new TcrMessageClientMarker(
+ new DataOutput(createDataOutput()), true)));
Review comment:
Can we refactor away this constant `true` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
