alb3rtobr opened a new pull request #6416: URL: https://github.com/apache/geode/pull/6416
`StartMemberUtils` contains utility methods used by `StartLocatorCommand` & `StartServerCommand`. One of them is `resolveWorkingDir` which returns the working directory to be used by the member. Part of the logic of this procedure is placed outside the function: ``` workingDirectory = StartMemberUtils.resolveWorkingDir(workingDirectory == null ? null : new File(workingDirectory), new File(memberName)); ``` This causes that tests of that function need to create an instance of `StartLocatorCommand` & `StartServerCommand` classes. And this has two negative consequences: * When a new startup parameter is added to locators and/or server, the tests of `resolveWorkingDir` have to be modified. * Tests are duplicated: there is a test class for every class using `resolveWorkingDir` (`StartLocatorCommandWorkingDirectoryTest` & `StartServerCommandWorkingDirectoryTest`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
