mivanac commented on a change in pull request #6427:
URL: https://github.com/apache/geode/pull/6427#discussion_r626058378
##########
File path:
geode-core/src/distributedTest/java/org/apache/geode/management/MemberMXBeanDistributedTest.java
##########
@@ -90,27 +90,26 @@ public void testBucketCount() {
assertThat(sumOfBuckets).isEqualTo(1000);
});
- for (int i = 1; i < 4; i++) {
- final String tempRegioName = regionName + i;
+ final int i = 1;
+ final String tempRegioName = regionName + i;
- gfsh.executeAndAssertThat("create region"
- + " --name=" + tempRegioName
- + " --type=PARTITION_PERSISTENT"
- + " --total-num-buckets=1000"
- + " --colocated-with=" + regionName).statusIsSuccess();
+ gfsh.executeAndAssertThat("create region"
+ + " --name=" + tempRegioName
+ + " --type=PARTITION_PERSISTENT"
+ + " --total-num-buckets=1000"
+ + " --colocated-with=" + regionName).statusIsSuccess();
- server1.invoke(() -> createBuckets(tempRegioName));
- server2.invoke(() -> createBuckets(tempRegioName));
- server3.invoke(() -> createBuckets(tempRegioName));
- server4.invoke(() -> createBuckets(tempRegioName));
- }
+ server1.invoke(() -> createBuckets(tempRegioName));
+ server2.invoke(() -> createBuckets(tempRegioName));
+ server3.invoke(() -> createBuckets(tempRegioName));
+ server4.invoke(() -> createBuckets(tempRegioName));
await().untilAsserted(() -> {
final int sumOfBuckets = server1.invoke(() -> getBucketsInitialized()) +
server2.invoke(() -> getBucketsInitialized()) +
server3.invoke(() -> getBucketsInitialized()) +
server4.invoke(() -> getBucketsInitialized());
- assertThat(sumOfBuckets).isEqualTo(4000);
+ assertThat(sumOfBuckets).isEqualTo(2000);
Review comment:
We have observed, when manually executing this test, in case we don`t
wait for bucket initialization to finish, in some cases, test will fail. So
solution is to wait for bucket initialization to finish, after each create
region command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
