dschneider-pivotal commented on a change in pull request #6435:
URL: https://github.com/apache/geode/pull/6435#discussion_r627585996
##########
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/StartServerCommand.java
##########
@@ -203,6 +204,10 @@ public ResultModel startServer(
String resolvedWorkingDirectory =
resolveWorkingDirectory(workingDirectory, memberName);
+ if (bindAddress != null && bindAddress.equals("*")) {
Review comment:
You could simplify this if to be "if ("*".equals(bindAddress))"
Also this if block is repeated in about 3 different places.
How about refactoring it into a new static method on LocalHostUtil?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
