agingade commented on a change in pull request #6423:
URL: https://github.com/apache/geode/pull/6423#discussion_r627685135
##########
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/CommandManager.java
##########
@@ -112,12 +121,10 @@ private static void raiseExceptionIfEmpty(Set<Class<?>>
foundClasses, String err
}
// Find by packages specified in the distribution config
- if (this.cacheProperties != null) {
- String cacheUserCmdPackages =
-
this.cacheProperties.getProperty(ConfigurationProperties.USER_COMMAND_PACKAGES);
- if (cacheUserCmdPackages != null && !cacheUserCmdPackages.isEmpty()) {
- userCommandSources.add(cacheUserCmdPackages);
- }
+ String cacheUserCmdPackages =
+
this.cacheProperties.getProperty(ConfigurationProperties.USER_COMMAND_PACKAGES,
"");
+ if (!cacheUserCmdPackages.isEmpty()) {
Review comment:
Is there a null check requirement here...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
