sabbey37 commented on a change in pull request #6444:
URL: https://github.com/apache/geode/pull/6444#discussion_r628237937
##########
File path:
geode-apis-compatible-with-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/string/AbstractDecrByIntegrationTest.java
##########
@@ -26,27 +26,30 @@
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
-import redis.clients.jedis.Jedis;
+import redis.clients.jedis.HostAndPort;
+import redis.clients.jedis.JedisCluster;
import redis.clients.jedis.Protocol;
import org.apache.geode.redis.RedisIntegrationTest;
import org.apache.geode.test.awaitility.GeodeAwaitility;
public abstract class AbstractDecrByIntegrationTest implements
RedisIntegrationTest {
- private Jedis jedis;
+ private JedisCluster jedis;
+ private final String hashTag = "{111}";
+ private final String someKey = "someKey" + hashTag;
Review comment:
We don't need the hash tag for `DECRBY` since it's not a multi-key
operation, but I guess it doesn't hurt to have it?
##########
File path:
geode-apis-compatible-with-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/string/AbstractBitOpIntegrationTest.java
##########
@@ -53,64 +62,65 @@ public void bitOp_errors_givenTooFewArguments() {
@Test
public void bitop_givenInvalidOperationType_returnsSyntaxError() {
assertThatThrownBy(
- () -> jedis.sendCommand(Protocol.Command.BITOP, "invalidOp",
"destKey", "srcKey"))
- .hasMessageContaining(ERROR_SYNTAX);
+ () -> jedis.sendCommand(hashTag, Protocol.Command.BITOP, "invalidOp",
"destKey" + hashTag,
+ "srcKey" + hashTag)).hasMessageContaining(ERROR_SYNTAX);
Review comment:
You could use the `destKey` and `srcKey` class variables you created
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
