nonbinaryprogrammer commented on pull request #6296: URL: https://github.com/apache/geode/pull/6296#issuecomment-834822202
> very minor, but if you end up making other changes: if > HASH_MAP_VALUE_PAIR_OVERHEAD & SIZE_OF_OVERHEAD_OF_FIRST_PAIR are the same value, do we need both? take a look at `RedisHashTest.constantFirstPairOverhead_shouldEqual_calculatedOverhead`; that's where the calculation for `SIZE_OF_OVERHEAD_OF_FIRST_PAIR` happens. The value is based off `HASH_MAP_VALUE_PAIR_OVERHEAD`, but is not necessarily equal, and has different meaning. so I do believe that the two are needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
