nonbinaryprogrammer commented on a change in pull request #6447:
URL: https://github.com/apache/geode/pull/6447#discussion_r628590932
##########
File path:
geode-apis-compatible-with-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/key/AbstractDelIntegrationTest.java
##########
@@ -97,10 +95,9 @@ public void testConcurrentDel_differentClients() {
AtomicLong deletedCount = new AtomicLong();
new ConcurrentLoopingThreads(ITERATION_COUNT,
(i) -> deletedCount.addAndGet(jedis.del(keyBaseName + i)),
- (i) -> deletedCount.addAndGet(jedis2.del(keyBaseName + i)))
+ (i) -> deletedCount.addAndGet(jedis.del(keyBaseName + i)))
Review comment:
at one point we needed two jedis's to do things concurrently. is that no
longer an issue with cluster mode? I have this same question about everywhere
that you deleted jedis2 and/or jedis3.
##########
File path:
geode-apis-compatible-with-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/key/AbstractScanIntegrationTest.java
##########
@@ -49,7 +49,7 @@ public void setUp() {
@After
public void tearDown() {
- jedis.flushAll();
+ flushAll();
jedis.close();
}
Review comment:
it looks to me like it's using JedisCluster, but maybe I'm missing
something
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
