jdeppe-pivotal commented on a change in pull request #6446:
URL: https://github.com/apache/geode/pull/6446#discussion_r631088308
##########
File path:
geode-apis-compatible-with-redis/src/distributedTest/java/org/apache/geode/redis/internal/executor/hash/HashesAndCrashesDUnitTest.java
##########
@@ -147,6 +149,12 @@ public void after() {
redisClient.shutdown();
}
+ @AfterClass
+ public static void tearDown() {
+ server1.stop();
+ server2.stop();
+ server3.stop();
+ }
Review comment:
This seems like the only significant change in this PR. Explicitly
stopping the servers shouldn't be required since the rule should take care of
cleaning up the servers. If that's not happening, then there's something wrong
with the rule. Did you run into issues somewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
