boglesby commented on a change in pull request #6441:
URL: https://github.com/apache/geode/pull/6441#discussion_r631470016
##########
File path: geode-gfsh/build.gradle
##########
@@ -25,6 +25,7 @@ dependencies {
api(project(':geode-core'))
api(project(':geode-common'))
+ api(project(':geode-wan'))
Review comment:
I see why you added that dependency. GatewaySenderBatchOp and GatewayAck
are in geode-wan module. You won't be able to add it to geode-core either, so
I think you'll need to add an API to GatewaySenderEventDispatcher (which is in
geode-core) for the sendBatch method. Something like:
```
sendBatch(Connection connection, PoolImpl senderPool, int batchId, int
replicatedEntries, long maxRate, long startTime, List batch)
throws InterruptedException, BatchException70 {
```
Then implement it in GatewaySenderEventRemoteDispatcher and I guess throw
UnsupportedOperationException in GatewaySenderEventCallbackDispatcher (unless
we want to support sending all events in a region to an AEQ too).
Then call it from the GatewaySender's eventProcessor.
I'll have to look at this more tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
