albertogpz opened a new pull request #6475: URL: https://github.com/apache/geode/pull/6475
when stopping gateway sender A bug was found in the SerialGatewaySenderQueue.hasEventsMatching() function that provoked that sometimes incomplete transactions were sent in batches when group-transaction-events is true, right before the gateway sender is stopped. The bug consisted in an error in the mentioned function that, when checking if there were events in the queue belonging to a transaction, did not check the event with the currentKey. Instead it started with the currentKey+1 until the tailkey was reached. This provoked that some transaction events received in the gateway sender during the grace period before it is stopped were not queued even though there were events in the queue for the same transaction. With the changes in this PR, the currentKey is also checked in the function to see if during the gateway sender stopping grace period a received event should be queued or not. A couple of small refactorings have also been made in the SerialGatewaySenderQueue class. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to [email protected]. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
