sabbey37 commented on a change in pull request #6493: URL: https://github.com/apache/geode/pull/6493#discussion_r635227676
########## File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/executor/pubsub/SubCommandExecutor.java ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + * + */ + + +package org.apache.geode.redis.internal.executor.pubsub; + +import java.util.Arrays; +import java.util.List; + +import org.apache.geode.redis.internal.executor.Executor; +import org.apache.geode.redis.internal.executor.RedisResponse; +import org.apache.geode.redis.internal.netty.Command; +import org.apache.geode.redis.internal.netty.ExecutionHandlerContext; + +public class SubCommandExecutor implements Executor { Review comment: Since there are a lot of commands in Redis that have sub commands, I think it would make more sense to follow the pattern of our other executors and name this after the primary command, so `PubSubExecutor` (also, all related test classes would need to be renamed.. Unfortunately we already have `AbstractPubSubIntegrationTest`... maybe that test class should be renamed?). Check out `ClusterExecutor`, which is named after the primary command, but has a case switch for sub commands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
