albertogpz edited a comment on pull request #6473: URL: https://github.com/apache/geode/pull/6473#issuecomment-845368576
> Is the "get-transaction-events-from-queue-retries" added only to help with the flakiness of tests (based on the description of the PR)? the xml attributes is user facing, should avoid adding very obscure meaning attributes if we can help it. @jinmeiliao Yes. At first, I only added it to the GatewaySender interface to be able to set it in test cases to avoid flakyness. Then I thought I should also add it to the xml file and gfsh interfaces. But we could just leave it in the GatewaySender interface and as a System property, as it already was. I have pushed a new commit without these parameters. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
