DonalEvans opened a new pull request #6511:
URL: https://github.com/apache/geode/pull/6511
- Rename ParameterRequirements to follow package naming best practices
- Add missing serialVersionUIDs
- Add final to fields and variables that can be final
- Fix various raw uses of parameterized classes
- Make variables local where possible
- Remove unused and redundant variables
- Remove some unused methods
- Remove uses of toArray() with pre-sized array argument. In older Java
versions using pre-sized array was recommended, as the reflection call
which is necessary to create an array of proper size was quite slow.
However since late updates of OpenJDK 6 this call was intrinsified,
making the performance of the empty array version the same and
sometimes even better, compared to the pre-sized version.
- Fix some typos
These changes reduce the number of inspection warnings in the
geode-apis-compatible-with-redis module from about 450 to about 136
Authored-by: Donal Evans <doev...@vmware.com>
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to d...@geode.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
