mivanac commented on a change in pull request #6474:
URL: https://github.com/apache/geode/pull/6474#discussion_r639199111
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/BucketRegionQueue.java
##########
@@ -423,8 +428,14 @@ public Object peek() {
}
key = this.eventSeqNumDeque.peekFirst();
if (key != null) {
+ boolean setDuplicate = markAsDuplicate.remove(key);
+
object = optimalGet(key);
Review comment:
markEventsAsDuplicate() marks all events in queue as duplicate at the
moment that bucket is becoming primary(and getNoLRU calls getValueInVM or
getValueOnDiskOrBuffer).
With new changes, events in queue will be marked as duplicate at the moment
that they are peeked/unqueued (optimalGet calls
getValueInVMOrDiskWithoutFaultIn)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
