jdeppe-pivotal commented on a change in pull request #6489:
URL: https://github.com/apache/geode/pull/6489#discussion_r639258737
##########
File path:
geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/executor/sortedset/ZAddExecutor.java
##########
@@ -47,7 +48,7 @@ public RedisResponse executeCommand(Command command,
ExecutionHandlerContext con
return RedisResponse
.integer(redisSortedSetCommands.zadd(command.getKey(),
- commandElements.subList(optionsFoundCount + 2,
commandElements.size()),
+ new ArrayList<>(commandElements.subList(optionsFoundCount + 2,
commandElements.size())),
Review comment:
Hmm. Do you remember which test broke? I reverted this change and ran
the new tests in this PR without any problems. Sorry to hold this up but I'd
hate for us to add an unnecessary allocation in a potentially fairly hot path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
