jvarenina commented on a change in pull request #6477:
URL: https://github.com/apache/geode/pull/6477#discussion_r639696518
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/TXCommitMessage.java
##########
@@ -391,9 +404,16 @@ void send(TXLockId lockId) {
setRecipientsSendData(Collections.singleton(indivRecip.next()), processor, rcl);
}
} else {
- // Run in normal mode sending to multiple recipients in
- // one shot
- setRecipientsSendData(recipients, processor, rcl);
+ if (this.notificationOnlyMembers.isEmpty()) {
+ // Run in normal mode sending to multiple recipients in one
shot
+ setRecipientsSendData(recipients, processor, rcl);
+ } else {
+ recipients.removeAll(this.notificationOnlyMembers);
+ setRecipientsSendData(recipients, processor, rcl);
+
+ this.txState.setTailKeyOnEntries(-1L);
+ setRecipientsSendData(notificationOnlyMembers, processor, rcl);
Review comment:
Yes this makes sense. In this case If I understood correctly we would
have to extend TXCommitMessage message with notificationOnly list of servers.
Is this correct? This seems like better solution, and I think it is manageable.
Also I have posted comment
https://github.com/apache/geode/pull/6477#issuecomment-848723153 with another
alternative which would require impact only on receiver side (adjunct member).
Could you please take a look and comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
