pivotal-eshu commented on a change in pull request #6524:
URL: https://github.com/apache/geode/pull/6524#discussion_r641052564
##########
File path:
geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSortedSet.java
##########
@@ -87,7 +87,9 @@ protected void applyDelta(DeltaInfo deltaInfo) {
membersAddAll(addsDeltaInfo);
} else {
RemsDeltaInfo remsDeltaInfo = (RemsDeltaInfo) deltaInfo;
- membersRemoveAll(remsDeltaInfo);
+ for (byte[] member : remsDeltaInfo.getRemoves()) {
+ memberRemove(member);
+ }
Review comment:
Actually I decide to keep the removeAll method as it uses synchronized
keyword - indicating potentially multiple threads can work on the data set. Use
removeAll and addAll, no additional thread will be able to modify members
concurrently -all or none.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
