luissson commented on a change in pull request #6525: URL: https://github.com/apache/geode/pull/6525#discussion_r641804640
########## File path: geode-apis-compatible-with-redis/src/distributedTest/java/org/apache/geode/redis/internal/executor/sortedset/ZCardDUnitTest.java ########## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.geode.redis.internal.executor.sortedset; + +import static org.apache.geode.distributed.ConfigurationProperties.MAX_WAIT_TIME_RECONNECT; +import static org.apache.geode.test.dunit.rules.RedisClusterStartupRule.DEFAULT_MAX_WAIT_TIME_RECONNECT; +import static org.assertj.core.api.Assertions.assertThat; + +import java.util.HashMap; +import java.util.Map; +import java.util.Properties; + +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.ClassRule; +import org.junit.Test; +import redis.clients.jedis.HostAndPort; +import redis.clients.jedis.Jedis; +import redis.clients.jedis.JedisCluster; + +import org.apache.geode.test.awaitility.GeodeAwaitility; +import org.apache.geode.test.dunit.rules.MemberVM; +import org.apache.geode.test.dunit.rules.RedisClusterStartupRule; + +public class ZCardDUnitTest { + + + @ClassRule + public static RedisClusterStartupRule clusterStartup = new RedisClusterStartupRule(4); + + private static final int SET_SIZE = 1000; + private static final String LOCAL_HOST = "127.0.0.1"; + private static final int JEDIS_TIMEOUT = + Math.toIntExact(GeodeAwaitility.getTimeout().toMillis()); + + private static MemberVM server1; + private static MemberVM server2; + private static MemberVM server3; + + private static JedisCluster jedis; + + + @BeforeClass + public static void classSetup() { + Properties locatorProperties = new Properties(); + locatorProperties.setProperty(MAX_WAIT_TIME_RECONNECT, DEFAULT_MAX_WAIT_TIME_RECONNECT); + + MemberVM locator = clusterStartup.startLocatorVM(0, locatorProperties); + int locatorPort = locator.getPort(); + + server1 = clusterStartup.startRedisVM(1, locatorPort); + server2 = clusterStartup.startRedisVM(2, locatorPort); + server3 = clusterStartup.startRedisVM(3, locatorPort); + + int redisServerPort = clusterStartup.getRedisPort(1); + + jedis = new JedisCluster(new HostAndPort(LOCAL_HOST, redisServerPort), JEDIS_TIMEOUT); + } + + @Before + public void beforeTest() { + try (Jedis conn = jedis.getConnectionFromSlot(0)) { + conn.flushAll(); + } + } + + @Test + public void shouldReturnSizeOfOneSet() { + String key = "key"; + Map<String, Double> memberScoreMap = makeMemberScoreMap("member1-"); + jedis.zadd(key, memberScoreMap); + + assertThat(jedis.zcard(key)).isEqualTo(SET_SIZE); + } + + @Test + public void shouldReturnSizeOfManySets_OnDifferentServers() { Review comment: Great suggestion, I've redone the test to randomize the set size and iterate the key. I've also checked the logs and see multiple servers carrying out zcard. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
