jhutchison commented on a change in pull request #6493:
URL: https://github.com/apache/geode/pull/6493#discussion_r645078092



##########
File path: 
geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/pubsub/Subscriptions.java
##########
@@ -67,6 +73,33 @@ boolean exists(Object channelOrPattern, Client client) {
         .collect(Collectors.toList());
   }
 
+  public List<byte[]> findChannelNames() {
+
+    ObjectOpenCustomHashSet<byte[]> hashSet =
+        new ObjectOpenCustomHashSet<>(ByteArrays.HASH_STRATEGY);
+
+    findChannels()
+        .forEach(channel -> hashSet.add(channel.getSubscriptionName()));

Review comment:
       as discussed, will put in a story to make the underlying collection in 
Subscriptions a Set instead of a List. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to