jinmeiliao commented on a change in pull request #6494:
URL: https://github.com/apache/geode/pull/6494#discussion_r645160555
##########
File path:
geode-core/src/main/java/org/apache/geode/management/internal/configuration/domain/Configuration.java
##########
@@ -164,9 +165,10 @@ public void toData(DataOutput out) throws IOException {
DataSerializer.writeString(propertiesFileName, out);
DataSerializer.writeProperties(gemfireProperties, out);
// Before 1.12, this code wrote a non-null HashSet of jarnames to the
output stream.
- // As of 1.12, it writes a null HashSet to the stream, so that when we can
still read the old
- // configuration, and will now also write the deployment map.
- DataSerializer.writeHashSet(null, out);
+ // As of 1.12, it will also send the hashmap with the deployments, so that
the new
+ // members can read the deployments while the older members can read just
the hashset
+ HashSet<String> jarNames = new HashSet<>(deployments.keySet());
+ DataSerializer.writeHashSet(jarNames, out);
Review comment:
do you need to make a change here? Can we continue to write `null` to
the stream instead of an empty set? this way, we can say, that if "jarName is
not null, then it's definitely pre 1.12).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
