agingade commented on pull request #5637:
URL: https://github.com/apache/geode/pull/5637#issuecomment-854120507
@masaki-yamakawa
My worry is abandoning the xml support in near future. If you insist to go
with this approach, its fine with me.
One change that could help code maintainability is moving your changes
(which is duplicate of the code/logic from
CreateMappingPreconditionCheckFunction) to RegionMapping as helper methods and
then accessing it from both place.
E.g.:
if (mapping.getFieldMappings().isEmpty() && mapping.getPdxName != null) {
mapping.createMappingUsingPdx();
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
