albertogpz commented on a change in pull request #6441:
URL: https://github.com/apache/geode/pull/6441#discussion_r645377571



##########
File path: 
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GatewayReceiverCommand.java
##########
@@ -350,6 +352,7 @@ public void cmdExecute(final Message clientMessage, final 
ServerConnection serve
               break;
 
             case 1: // Update
+            case GatewaySenderEventImpl.UPDATE_ACTION_NO_GENERATE_CALLBACKS:
               try {

Review comment:
       In case the remote site is in an older version, the batch will be 
rejected as the operation will be unknown. A message log like the following 
will be sent: "Unknown action type 4 for batch from ...".
   The problem with the current behavior is that the receiver will keep trying 
to apply that operation forever. I think this is something that should be 
corrected in the future as it does not make sense to retry an operation that 
will never succeed.
   We could state in the documentation, that, in order for this command to 
work, both sides must be in the version the command was introduced or in a 
higher one.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to